stats: add support for multiple stats handlers in a single client or server #5347
+219
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump. |
|
Bump again. PTAL. Let me know if there is any problem with the design or idea or code. |
1. Pluralize the variable names for slices 2. Remove the unnecessary ifs 3. Simplify the unit test
|
@dfawley PTALA. The check-in-loop in stats_test is actually necessary. After graceful shutdown of server, the ConnEnd events might not be counted, and causing the test to fail: https://github.com/grpc/grpc-go/runs/6699361791?check_suite_focus=true . For client-side, the close of channel doesn't mean all processing logic on the client-side is finished, hence the problem. Other renaming or optimizations (remove if) are done. |
|
The failure is unrelated. |
dfawley
approved these changes
Jun 2, 2022
dfawley
reviewed
Jun 2, 2022
|
@dfawley PTALAAA. |
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
The user-facing interface is unchanged, but the behavior is slightly different. (We discussed this) If a user application intentionally sets StatsHandler repeatedly and only expects the last one to be effective, we will break them.
RELEASE NOTES: