weightedtarget: return a more meaningful error when no child policy is reporting READY (#5391) #5711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/easycla |
|
/easycla |
easwars
requested changes
Oct 12, 2022
easwars
requested changes
Oct 13, 2022
arvindbr8
force-pushed
the
5391
branch
3 times, most recently
from
6286136
to
67db576
Compare
easwars
approved these changes
Oct 17, 2022
| @@ -274,7 +279,8 @@ func (s) TestEDSPriority_SwitchPriority(t *testing.T) { | |||
| } | |||
|
|
|||
| // Should get an update with 1's old picker, to override 2's old picker. | |||
| if err := testErrPickerFromCh(cc.NewPickerCh, balancer.ErrTransientFailure); err != nil { | |||
| want := errors.New("last connection error: subConn connection error") | |||
| if err := testErrPickerFromCh(cc.NewPickerCh, want); err != nil { | |||
There was a problem hiding this comment.
I was about to make the same comment as I did on the other file for here, but realized that testErrPickerFromCh performs a reflect.DeepEqual() on the got and want errors, instead of doing a strings.Contains(). Would you mind fixing the implementation of testErrPickerFromCh to do the latter instead. It doesn't have to be done in this PR. You can send another PR for that after this is merged. Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all the child policies are in
TRANSIENT_FAILURE, theweightedtargetLB policy currently sends a picker which always returnsbalancer.ErrTransientFailureerror message. This error does not provide any info to the user regarding the underlying issue for the failure. With this change we are surfacing the underlying error by sending back the error picker.Fixes #5391
RELEASE NOTES: