grpc: skip compression of empty messages #6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes grpc#6831. This avoids compressing messages that are empty, since you can't compress zero bytes to anything smaller than zero bytes, and most compression algorithms output headers and trailers which means the resulting message will be non-zero bytes.
jroper
force-pushed
the
skip-compress-empty
branch
from
21d57db
to
1591994
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6842 +/- ##
==========================================
+ Coverage 83.33% 83.65% +0.32%
==========================================
Files 285 286 +1
Lines 30879 30804 -75
==========================================
+ Hits 25732 25769 +37
+ Misses 4067 3976 -91
+ Partials 1080 1059 -21
|
easwars
added
the
Type: Performance
easwars
approved these changes
Dec 13, 2023
easwars
changed the title
dfawley
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6831.
This avoids compressing messages that are empty, since you can't compress zero bytes to anything smaller than zero bytes, and most compression algorithms output headers and trailers which means the resulting message will be non-zero bytes.
RELEASE NOTES: