retries:Remove early commit for transparent retries with none remaining. #10066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YifeiZhuang
reviewed
Apr 18, 2023
YifeiZhuang
approved these changes
Apr 19, 2023
ejona86
added
the
TODO:backport
|
@larry-safran, let's backport this to 1.54, 1.53, and 1.50. We won't do releases, but if we do a release for another reason, they'll be there. |
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Apr 19, 2023
…ng. (grpc#10066) * retries:Remove early commit for transparent retries when no retries or no hedging remain. Fixes grpc#10011
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Apr 19, 2023
…ng. (grpc#10066) * retries:Remove early commit for transparent retries when no retries or no hedging remain. Fixes grpc#10011
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Apr 19, 2023
…ng. (grpc#10066) * retries:Remove early commit for transparent retries when no retries or no hedging remain. Fixes grpc#10011
This was referenced Apr 19, 2023
Merged
Merged
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RetriableStream was trying to do an optimization by doing early commits when there were not going to be any further explicit retries, but it should never have been done. This is removing the optimization and reversing the test that checked for an early commit.
Fixes #10011