Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servlet: tomcat does not support trailer only #10124

Open
hypnoce opened this issue May 3, 2023 · 0 comments · May be fixed by #10125
Open

servlet: tomcat does not support trailer only #10124

hypnoce opened this issue May 3, 2023 · 0 comments · May be fixed by #10125
Milestone
Next

Comments

@hypnoce
Copy link
Contributor

hypnoce commented May 3, 2023 •
edited

gRPC version:
1.53.0
gRPC server transport: servlet
gRPC client transport: netty

What is your environment?

MacOS 12.4 jdk11

What did you expect to see?

This is a known behaviour where tomcat sends an empty data frame with a end_stream flag instead of a trailer only frame with end_stream flag. While it is a valid http2 behaviour, this is not supported by gRPC who expected end_stream frames to be sent in trailer or trailer-only frame.

What did you see instead?

Internal status error because a data frame is end_stream

Steps to reproduce the bug

The transport tests earlyServerClose_noServerHeaders, earlyServerClose_serverFailure and earlyServerClose_serverFailure_withClientCancelOnListenerClosed reproduce the problem
hypnoce pushed a commit to hypnoce/grpc-java that referenced this issue May 3, 2023
servlet: force always sending end_stream in trailer frame (Fixes grpc…
9fa3e75 
…#10124)

Signed-off-by: hypnoce <hypnoce@gmail.com>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 3, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
c96be19 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 3, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
0d0d716 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
@hypnoce hypnoce linked a pull request May 3, 2023 that will close this issue
Open
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 3, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
1cd5746 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 4, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
a617e77 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 4, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
abbf897 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 4, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
a61ae5e 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 5, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
492f610 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 5, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
d7351ca 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 5, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
c6f858b 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 5, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
3f797f7 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 10, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
7b79234 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 10, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
f02f616 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 10, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
f31de56 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 10, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
4b0d14f 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue May 12, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
63221e3 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue Aug 1, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
63bb258 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
hypnoce added a commit to hypnoce/grpc-java that referenced this issue Nov 23, 2023
@hypnoce
servlet: force always sending end_stream in trailer frame (Fixes grpc…
2eda56a 
…#10124)

Signed-off-by: hypnoce <hypnoce@donarproject.org>
@sergiitk sergiitk added this to the 1.61 milestone Dec 5, 2023
@sergiitk sergiitk modified the milestones: 1.61, 1.62 Jan 11, 2024
@larry-safran larry-safran modified the milestones: 1.62, Next Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

servlet: force always sending end_stream in trailer frame (Fixes #10124) hypnoce/grpc-java
3 participants
@sergiitk @hypnoce @larry-safran