Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add java toolchain type to all rules which are using java_common #10225

Merged
merged 1 commit into from May 30, 2023
Merged

Add java toolchain type to all rules which are using java_common #10225

merged 1 commit into from May 30, 2023

Conversation

kotlaja
Copy link
Contributor

@kotlaja kotlaja commented May 26, 2023 •
edited by sergiitk

ref cl/534798532

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 26, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

sergiitk
sergiitk approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved it, but to merge it signing CLA is required.

@sergiitk sergiitk enabled auto-merge (squash) May 26, 2023 21:55
@sergiitk sergiitk added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label May 30, 2023
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label May 30, 2023
@sergiitk sergiitk requested a review from ejona86 May 30, 2023 18:29
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label May 30, 2023
@sergiitk sergiitk merged commit e6d9b41 into grpc:master May 30, 2023
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kotlaja @sergiitk @ejona86 @grpc-kokoro