You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(note: I'm describing the issue as I recollect it; Chat ate the discussion thread. @markb74 please correct me if I'm wrong)
#10633 introduced the PendingAuthListener class and the logic to handle AsyncSecurityPolicy without blocking any threads. This required an Executor to be passed to BinderTransportSecurityhere. In the same PR, we added a shutdown listener to return that executor to the object pool during server shutdown (here).
@markb74 commented that this was sub-optimal, and we could instead return the executor during termination. One suggestion was to pass an Executor to BinderServer.start and reuse it throught that server's lifetime. I prototyped it in mateusazis@3f262ca, but ended up with a chicken-and-egg issue in BinderServerBuilder.build:
BinderTransportSecurity.installAuthInterceptor wants an Executor, but it will only be available on BinderServer after it is instantiated and started
BinderServer is only instantiated after the authorization interceptor gets installed
Any help here is welcome!
The text was updated successfully, but these errors were encountered:
This is a follow-up to #10566.
(note: I'm describing the issue as I recollect it; Chat ate the discussion thread. @markb74 please correct me if I'm wrong)
#10633 introduced the
PendingAuthListener
class and the logic to handleAsyncSecurityPolicy
without blocking any threads. This required anExecutor
to be passed toBinderTransportSecurity
here. In the same PR, we added a shutdown listener to return that executor to the object pool during server shutdown (here).@markb74 commented that this was sub-optimal, and we could instead return the executor during termination. One suggestion was to pass an
Executor
toBinderServer.start
and reuse it throught that server's lifetime. I prototyped it in mateusazis@3f262ca, but ended up with a chicken-and-egg issue inBinderServerBuilder.build
:BinderTransportSecurity.installAuthInterceptor
wants an Executor, but it will only be available onBinderServer
after it is instantiated and startedBinderServer
is only instantiated after the authorization interceptor gets installedAny help here is welcome!
The text was updated successfully, but these errors were encountered: