Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include network four-tuple for connections in io.grpc.ChannelLogger logs #10936

Open
ejona86 opened this issue Feb 21, 2024 · 0 comments
Open
Assignees
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented Feb 21, 2024

We can't include them in each log message, because we simply don't know the values much of the time. But specifically for the transportReady and transportShutdown notifications, it seems we can plumb it without synchronization. We can add methods to ManagedClientTransport to get the local/remote addresses, maybe just as a getAttributes() method.

There's probably some status messages that would also be useful to include the four-tuple, but it may be hard to track them. Maybe we could include it in the DEADLINE_EXCEEDED message we generate.

@ejona86 ejona86 added this to the Next milestone Feb 21, 2024
@ejona86 ejona86 self-assigned this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant