Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Java 9 modules #4085

Closed
ejona86 opened this issue Feb 14, 2018 · 4 comments
Closed

Create Java 9 modules #4085

ejona86 opened this issue Feb 14, 2018 · 4 comments
Assignees
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented Feb 14, 2018

Java 9 modules solve many causes of version collision issues, which would greatly help users. Granted, it's not helpful unless people are actually on Java 9.

This is probably blocked by #3522. It'd probably be reasonable to wait for #4084 as well.

https://guides.gradle.org/building-java-9-modules/

@ejona86 ejona86 added this to the Next milestone Feb 14, 2018
@hohwille
Copy link

[WARNING] ***********************************************************************************************************************************************
[WARNING] * Required filename-based automodules detected: [protobuf-java-3.9.2.jar]. Please don't publish this project to a public artifact repository! *
[WARNING] ***********************************************************************************************************************************************

You can easily add a MANIFEST.MF with module name. Via Maven I have provided this for TeaVM here:
https://github.com/konsoletyper/teavm/pull/490/files

@ejona86
Copy link
Member Author

ejona86 commented Mar 15, 2021

@hohwille, protobuf-java is part of https://github.com/protocolbuffers/protobuf

@sanjaypujare
Copy link
Contributor

Can this be considered fixed with automatic module name support?

@ejona86 ejona86 modified the milestones: Next, 1.58 Sep 5, 2023
@ejona86
Copy link
Member Author

ejona86 commented Sep 5, 2023

Yeah, automatic module name works. Fixed by #10413

@ejona86 ejona86 closed this as completed Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants