Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document expectations about NameResolver SocketAddresses #5213

Open
carl-mastrangelo opened this issue Jan 7, 2019 · 2 comments
Open

Document expectations about NameResolver SocketAddresses #5213

carl-mastrangelo opened this issue Jan 7, 2019 · 2 comments
Milestone

Comments

@carl-mastrangelo
Copy link
Contributor

Currently, a name resolver returns a collection of SocketAddress wrapped up in EquivalentAddressGroups. In the most common case InetSocketAddress will be used. Currently there are no expectations about the data in the address, but I believe we need to clarify this.

This came up in working with HTTP Proxies. In case a Proxy is used, Netty can derive the the initial CONNECT message from the InetSocketAddress hostname. This may be present or may not, but the behavior of this may change based on what the name resolver returns.

I don't know what to say here, other than it may be absent, but I wanted to open up a discussion because it recently came up.

@carl-mastrangelo
Copy link
Contributor Author

cc @ejona86 @zhangkun83

@ejona86
Copy link
Member

ejona86 commented Jan 12, 2019

Right now it's basically "use InetSocketAddress" as everything else won't work. But as was mentioned in that other discussion #3085 will open of more alternatives.

So I'm not really sure what you're hoping will happen before #3085 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants