Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resolved versions instead of resolutionStrategy.failOnVersionConflict #5528

Closed
ejona86 opened this issue Apr 1, 2019 · 1 comment
Closed

Comments

@ejona86
Copy link
Member

ejona86 commented Apr 1, 2019

Gradle 5.2 added support for publishing the resolved versions of dependencies used.

We are currently using failOnVersionConflict because we didn't have a way to check that Maven would resolve dependencies correctly. Although failOnVersionConflict is similar to Maven Enforcer's dependencyConvergence, we only care about supporting requireUpperBoundDeps.

Unfortunately, resolved versions seems to be sufficient only for direct dependencies. A transitive dependency included twice could have the lesser of the two versions first (and so Maven would chose the wrong one). That may not happen very often, so we could potentially rely on things like https://storage.googleapis.com/cloud-opensource-java-dashboard/dashboard/target/dashboard/dashboard.html to notice failures. failOnVersionConflict is a PITA and error-prone, so even suboptimal tradeoffs may be welcome.

Using resolved versions is also of interest to #4680.

@ejona86 ejona86 added this to the Next milestone Apr 1, 2019
@ejona86
Copy link
Member Author

ejona86 commented Aug 30, 2021

failOnVersionConflict was replaced with a different approach in #8238.

@ejona86 ejona86 closed this as completed Aug 30, 2021
@ejona86 ejona86 removed this from the Next milestone Aug 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant