Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerCall.Listener.onComplete not exposed to async stub #5895

Closed
ejona86 opened this issue Jun 18, 2019 · 3 comments
Closed

ServerCall.Listener.onComplete not exposed to async stub #5895

ejona86 opened this issue Jun 18, 2019 · 3 comments
Assignees
@ejona86
Labels
enhancement good first issue
Milestone
1.42

Comments

@ejona86
Copy link
Member

ejona86 commented Jun 18, 2019

@TMilasius in #5882 was needing a point to free up resources. That is onComplete/onCancel in the ServerCall API. But we don't expose onComplete. We'll have to deal with naming collisions with StreamObserver itself, but we should expose a way to receive the onComplete notification, probably by providing a runnable in the same way as onCancel.
@ejona86 ejona86 added this to the Next milestone Jun 18, 2019
@ejona86 ejona86 self-assigned this Jun 18, 2019
@ejona86 ejona86 mentioned this issue Jun 18, 2019
Closed
@ejona86 ejona86 modified the milestones: Next, Unscheduled Jun 28, 2019
@ejona86
Copy link
Member Author

ejona86 commented Jun 28, 2019

Moving to unscheduled since @TMilasius mentioned in #5882 it wasn't strictly necessary and the name collision is a concern.

@ejona86 ejona86 mentioned this issue Aug 20, 2021
Closed
morgwai added a commit to morgwai/grpc-java that referenced this issue Aug 26, 2021
@morgwai
stub: add ServerCallStreamObserver.setOnSuccessHandler(...) (grpc#5895)
b68d403 
This allows for user code to be notified when the messages are actually
put on the wire and the stream is closed.
@morgwai
Copy link
Contributor

morgwai commented Aug 31, 2021

@ejona86 #8452

@morgwai morgwai mentioned this issue Sep 1, 2021
Open
@ejona86
Copy link
Member Author

ejona86 commented Sep 21, 2021

Initial API review was in #8467 (comment)

@ejona86 ejona86 modified the milestones: Unscheduled, 1.42 Sep 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ejona86 ejona86

Labels
enhancement good first issue
Projects
None yet
Milestone
1.42
Development

No branches or pull requests
2 participants
@morgwai @ejona86