Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: allow setting custom Deadline.Ticker to InProcessServerBuilder #6034

Merged
merged 3 commits into from Aug 1, 2019

Conversation

zhangkun83
Copy link
Contributor

ServerImpl uses that ticker to create incoming Deadlines. This feature is specifically restricted to in-process, as it can also customize ScheduledExecutorService, and them together can fake out the clock which is useful in tests. On the other hand, a fake Ticker won't work with Netty's ScheduledExecutorService.

Also improved mismatch detection, documentation and tests in Deadline.

Resolves #2531

@zhangkun83 zhangkun83 merged commit 4e4d4d8 into grpc:master Aug 1, 2019
@zhangkun83 zhangkun83 deleted the ticker_on_server_builder branch August 1, 2019 20:13
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Deadline test-friendly
2 participants