Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: handle removing partially-closed resources for throwing on close. Fixes #6002 #6044

Merged
merged 1 commit into from Aug 8, 2019
Merged

core: handle removing partially-closed resources for throwing on close. Fixes #6002 #6044

merged 1 commit into from Aug 8, 2019

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Aug 8, 2019 •
edited

Resolves #6002.

zhangkun83
zhangkun83 approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@zhangkun83 zhangkun83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was there a bug reported for this?

@voidzcy voidzcy force-pushed the bugfix/shared_resource_holder_remove_partially_closed_resources branch from 98d9040 to 88360fd Compare August 8, 2019 21:02
@voidzcy voidzcy force-pushed the bugfix/shared_resource_holder_remove_partially_closed_resources branch from 88360fd to 91eb998 Compare August 8, 2019 21:03
@voidzcy voidzcy changed the title core: handle removing partially-closed resources for throwing on close core: handle removing partially-closed resources for throwing on close. Fixes #6002 Aug 8, 2019
@voidzcy
Copy link
Contributor Author

voidzcy commented Aug 8, 2019

LGTM. Was there a bug reported for this?

Updated.

@voidzcy voidzcy merged commit 539f040 into grpc:master Aug 8, 2019
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Aug 8, 2019
@voidzcy
core: handle removing partially-closed resources for throwing on close.
660f635 
Fixes grpc#6002. (grpc#6044)
@voidzcy voidzcy mentioned this pull request Aug 8, 2019
Merged
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Aug 8, 2019
@voidzcy
core: handle removing partially-closed resources for throwing on close.
80fca2e 
Fixes grpc#6002. (grpc#6044)
@voidzcy voidzcy mentioned this pull request Aug 8, 2019
Merged
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Aug 8, 2019
@voidzcy
core: handle removing partially-closed resources for throwing on close.
c2e601a 
Fixes grpc#6002. (grpc#6044)
@voidzcy voidzcy mentioned this pull request Aug 8, 2019
Merged
voidzcy added a commit that referenced this pull request Aug 8, 2019
@voidzcy
core: handle removing partially-closed resources for throwing on close.
8779c6a 
Fixes #6002. (#6044) (#6046)
voidzcy added a commit that referenced this pull request Aug 8, 2019
@voidzcy
core: handle removing partially-closed resources for throwing on close.
54084b9 
Fixes #6002. (#6044) (#6047)
voidzcy added a commit that referenced this pull request Aug 8, 2019
@voidzcy
core: handle removing partially-closed resources for throwing on close.
0736411 
Fixes #6002. (#6044) (#6048)
@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@zhangkun83 zhangkun83 zhangkun83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SharedResourceHolder should roughly handle exceptions during close
3 participants
@voidzcy @ejona86 @zhangkun83