Fix java path separator bug on Windows #6054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java_grpc_library
targets based onjava_proto_library
targets with more than oneproto_library
dependency can't be built on Windows, starting somewhere before 1.22. A minimal reproducing example is available on https://github.com/Xjs/bazel-grpc-java-win-repro (seeREADME.md
there for output on my machine as well as steps to reproduce).The issue stems from
protoc
configuring a different path separator for Windows at compile time in combination withjava_grpc_library
always using:
.This PR uses the path separator available from the bazel context's host_configuration to resolve the issue.