android: final stabilization of AndroidChannelBuilder #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Aug 27, 2019
| @@ -388,94 +388,4 @@ public void enterIdle() { | |||
| enterIdleCount++; | |||
| } | |||
| } | |||
|
|
|||
| private static class ScheduledExecutorImpl implements ScheduledExecutorService { | |||
There was a problem hiding this comment.
This is something in the test that I (unfortunately) forgot to delete last time when deleting the related test methods.
There was a problem hiding this comment.
Do that in a separate PR. If this API change was reverted, we wouldn't want to revert the deletion.
There was a problem hiding this comment.
Sure, it's in #6098. (And sorry for the force-push...)
| @@ -51,7 +50,6 @@ | |||
| * | |||
| * @since 1.12.0 | |||
| */ | |||
| @ExperimentalApi("https://github.com/grpc/grpc-java/issues/6043") | |||
There was a problem hiding this comment.
Go ahead and copy this to the @Deprecated method. In general, we can't remove deprecated methods. We can only remove this one because it was never stabilized.
voidzcy
force-pushed
the
api/stabilize_android_channel_builder_step_three_remove_annotation
branch
from
1e7067f
to
4129de5
Compare
ejona86
approved these changes
Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6043.
Upon this point,
AndroidChannelBuilderis considered to be stabilized (fromBuidler(...)is deprecated and will be kept for a couple of releases).