Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: fix builder invocation for converting Google service account to Jwt access credential #6106

Merged
merged 3 commits into from Aug 30, 2019
Merged

auth: fix builder invocation for converting Google service account to Jwt access credential #6106

merged 3 commits into from Aug 30, 2019

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Aug 29, 2019

Resolves #6105 .

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 29, 2019 •
edited

CLA Check
The committers are authorized under a signed CLA.

@voidzcy voidzcy requested a review from ejona86 August 29, 2019 19:03
@voidzcy voidzcy requested review from ejona86 and removed request for ejona86 August 29, 2019 19:26
@ejona86
Copy link
Member

ejona86 commented Aug 30, 2019

Comment to see if easycla notices.

@voidzcy
Copy link
Contributor Author

voidzcy commented Aug 30, 2019

Ping for CLA.

@voidzcy voidzcy merged commit efc14bd into grpc:master Aug 30, 2019
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Sep 3, 2019
@voidzcy
auth: fix builder invocation for converting Google service account to…
4c04c51 
… Jwt access credential (grpc#6106)

* Fixed mistaken method invocation for privateKeyId getter/setter.

* Added test coverage to verify jwt credentials are applied to request metadata correctly.

* No need to expose serviceUri method for testing.
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Sep 3, 2019
@voidzcy
auth: fix builder invocation for converting Google service account to…
3dbf2ba 
… Jwt access credential (grpc#6106)

* Fixed mistaken method invocation for privateKeyId getter/setter.

* Added test coverage to verify jwt credentials are applied to request metadata correctly.

* No need to expose serviceUri method for testing.
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Sep 3, 2019
@voidzcy
auth: fix builder invocation for converting Google service account to…
3a2e616 
… Jwt access credential (grpc#6106)

* Fixed mistaken method invocation for privateKeyId getter/setter.

* Added test coverage to verify jwt credentials are applied to request metadata correctly.

* No need to expose serviceUri method for testing.
This was referenced Sep 3, 2019
Merged
Closed
Closed
Merged
Merged
voidzcy added a commit that referenced this pull request Sep 4, 2019
@voidzcy
auth: fix builder invocation for converting Google service account to…
871c8f4 
… Jwt access credential (#6106) (#6124)

* Fixed mistaken method invocation for privateKeyId getter/setter.

* Added test coverage to verify jwt credentials are applied to request metadata correctly.

* No need to expose serviceUri method for testing.
voidzcy added a commit that referenced this pull request Sep 4, 2019
@voidzcy
auth: fix builder invocation for converting Google service account to…
9482db6 
… Jwt access credential (#6106) (#6123)

* Fixed mistaken method invocation for privateKeyId getter/setter.

* Added test coverage to verify jwt credentials are applied to request metadata correctly.

* No need to expose serviceUri method for testing.
voidzcy added a commit that referenced this pull request Sep 4, 2019
@voidzcy
auth: fix builder invocation for converting Google service account to…
0572107 
… Jwt access credential (#6106) (#6120)

* Fixed mistaken method invocation for privateKeyId getter/setter.

* Added test coverage to verify jwt credentials are applied to request metadata correctly.

* No need to expose serviceUri method for testing.
@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@voidzcy @ejona86