Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android kokoro build is very flaky #6146

Closed
dapengzhang0 opened this issue Sep 12, 2019 · 13 comments
Closed

Android kokoro build is very flaky #6146

dapengzhang0 opened this issue Sep 12, 2019 · 13 comments
Milestone

Comments

@dapengzhang0
Copy link
Member

Android kokoro build became very flaky after #6103

@dapengzhang0 dapengzhang0 added the highly flaky Issue is for a test that is crying wolf label Sep 12, 2019
@voidzcy
Copy link
Contributor

voidzcy commented Sep 12, 2019

The Gradle build seems to hit memory limit easily after we adding ./gradlew clean. I was try to increase the Metaspace limit in #6148, but it doesn't seem to work.

@ejona86 ejona86 added this to the 1.25 milestone Sep 17, 2019
@dapengzhang0 dapengzhang0 removed the highly flaky Issue is for a test that is crying wolf label Sep 18, 2019
@dapengzhang0
Copy link
Member Author

Removing the highly flaky label as it is not seen again this week. It may also be possible that flakiness occurred after #6103 is by coincidence.

@ejona86
Copy link
Member

ejona86 commented Sep 18, 2019

#6103 actually seems a reasonable trigger, because it means the gradle task rebuilds more code. It looks like the failures resolved after #6131 was merged (it is the only PR between the last failure and first success), which is not wholly unreasonable. It isn't completely clear to me why that PR fixed it, but the change impacted gradle enough it does make some sense.

I'm going to mark this as resolved. It could easily rear its head again, but it seems resolved for the while.

@ejona86 ejona86 closed this as completed Sep 18, 2019
@dapengzhang0
Copy link
Member Author

I believe #6131 resolves this issue. Actually #6131 itself fails the android build because it was rebuilding head^ with the old build.gradle, but once it's merged no more PR fails.

@ejona86
Copy link
Member

ejona86 commented Oct 2, 2019

Uh, oh. This may be resurfacing. I just saw https://source.cloud.google.com/results/invocations/8dcbb963-10c3-43e5-9345-9e0a3a7ed6b6

@ejona86
Copy link
Member

ejona86 commented Oct 2, 2019

Actually. That's because it is on the v1.24.x branch. I guess we need a fix for the branch.

@dapengzhang0
Copy link
Member Author

dapengzhang0 commented Oct 2, 2019

An easy way to fix 1.24.x branch is to revert #6103

Edit: The "easy fix" above actually does not fix.

@ejona86
Copy link
Member

ejona86 commented Oct 2, 2019

@dapengzhang0, ah, yeah, that would probably work well. Would you mind sending out a PR?

@creamsoup
Copy link
Contributor

I encountered same issue of my backport to 24. this fix is also backported, so reopening the issue.

https://source.cloud.google.com/results/invocations/f47ddafa-0b41-4c79-97cc-01e050129fa8/targets/grpc%2Fjava%2Fv1.24.x%2Fpresubmit%2Fandroid/log

@creamsoup creamsoup reopened this Nov 5, 2019
@dapengzhang0
Copy link
Member Author

@creamsoup This happens in some old branches (where #6131 is not in), even #6103 is reverted.

@creamsoup
Copy link
Contributor

okay. this is only happening in older branches, closing it. please reopen if this happens in 1.25.x or newer.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants