Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alts: add close to TsiHandshaker to avoid resource leak for some impls #6186

Merged
merged 2 commits into from Sep 25, 2019

Conversation

creamsoup
Copy link
Contributor

@creamsoup creamsoup commented Sep 24, 2019

Some handshaker implementation has internal closable resources. It only works if everything goes well (current implementation relying on the internal resource closes itself).

In failure case, it may cause leak depends on the implementation of tsi handshaker. Having close in TsiHandshaker and TsiHandshakeHandler explicitly close the handshaker should avoid such leak; less error prone.

@creamsoup creamsoup merged commit 1ab6510 into grpc:master Sep 25, 2019
@creamsoup creamsoup deleted the tsi branch September 25, 2019 20:23
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants