Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "stub: Wait for onClose when blocking stub is interrupted"" #6255

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Oct 7, 2019

This reverts commit 0604e14.

Previously, the change caused an internal test to hang. But this was caused by Exoblaze (Bazel's BuildEventServiceModule)'s timeout management. Not 100% sure, but I am suspecting that it's logic in waiting for shutdown on the same thread (which is the same thread as gRPC's transport thread) caused the CancelClientStreamCommand never had chance to run.

The issue was fixed in bazelbuild/bazel@82f5090#diff-a4dcfc83b91b9ec1e362e379e4331377R417. So nothing needs to be done on our side and we can proceed to roll this forward.

Previous broken tests have passed after applying this change to latest Exoblaze.

Resolves #5576.

@voidzcy voidzcy changed the title Revert "Revert "stub: Wait for onClose when blocking stub is interrup… Revert "Revert "stub: Wait for onClose when blocking stub is interrupted"" Oct 7, 2019
@voidzcy voidzcy requested a review from ejona86 October 7, 2019 18:09
@ejona86
Copy link
Member

ejona86 commented Oct 7, 2019

Thank you for tracking this down!

@voidzcy voidzcy merged commit 0ec31c6 into grpc:master Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClientCall errors does not finally invoke ClientCall.Listener.onClose()
2 participants