Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf: StatusProto#fromStatusAndTrailers fall-back use status #6278

Merged
merged 3 commits into from Oct 15, 2019

Conversation

creamsoup
Copy link
Contributor

the original intention was only generating Status proto from trailers. In actual use cases requires to handle null and derive the Status proto from status. The main reason is there are few cases when the server doesn't send trailers such as server UNREACHABLE, UNAVAILABLE or DEADLINE_EXCEEDED.

@creamsoup creamsoup requested a review from ran-su October 15, 2019 00:49
@creamsoup creamsoup merged commit eda5e2e into grpc:master Oct 15, 2019
@creamsoup creamsoup deleted the status branch October 15, 2019 15:49
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants