New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComputeEngineChannelBuilder has wrong signature #6367
Labels
Comments
dapengzhang0
added
bug
TODO:release blocker
Issue/PR is important enough to delay the release. Removed after release issues resolved
labels
Oct 31, 2019
Did the following tests:
ManagedChannel channel = ComputeEngineChannelBuilder.forTarget(serverAddress)
.build();
ManagedChannel channel = ComputeEngineChannelBuilder.forTarget(serverAddress)
.keepAliveTime(10, TimeUnit.MINUTES).build(); or ManagedChannelBuilder<GoogleDefaultChannelBuilder> builder =
ComputeEngineChannelBuilder.forTarget(serverAddress);
ManagedChannel channel = builder.keepAliveTime(10, TimeUnit.MINUTES).build();
So either no existing users are writing code like above or they have broken code like this but never tested it.
ManagedChannel channel = ComputeEngineChannelBuilder.forTarget(serverAddress)
.build(); as well as ManagedChannelBuilder<?> builder = ComputeEngineChannelBuilder.forTarget(serverAddress);
ManagedChannel channel = builder.keepAliveTime(10, TimeUnit.MINUTES).build(); Both can run. So we can fix the signature directly without breaking ABI for existing users. |
This was referenced Nov 1, 2019
ejona86
removed
the
TODO:release blocker
Issue/PR is important enough to delay the release. Removed after release issues resolved
label
Nov 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The generic type in
ComputeEngineChannelBuilder
class signatureis wrong, it should be
ForwardingChannelBuilder<ComputeEngineChannelBuilder>
However, fixing the bug might be ABI breaking for existing users.
cc @zhangkun83
The text was updated successfully, but these errors were encountered: