netty: provide an option to lower netty allocator chunk size from 16MB to 2MB #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Nov 11, 2019
…ted by system property
zhangkun83
changed the title
zhangkun83
changed the title
ericgribkoff
pushed a commit
to ericgribkoff/grpc-java
that referenced
this pull request
Dec 6, 2019
…B to 2MB (grpc#6407) This would reduce the amount of direct buffer allocations, especially with light traffic. This should mitigate internal issue b/143075435 The change is currently optional and is only effective if system property "io.grpc.netty.useCustomAllocator" is set to "true" ignoring the case. Internal benchmark results (median of 5 runs) doesn't show any significant change: ``` Before (STDEV) After (STDEV) grpc-java-java-multi-qps-integrity_only Actual QPS 717,848 (7,445) 715,061 (2,122) QPS per Client CPU 23,768 (799) 23,842 (295) grpc-java-java-multi-throughput-integrity_only Actual QPS 35,631 (204) 35,298 (25) QPS per Client CPU 3,362 (56) 3,316 (18) grpc-java-java-single-latency-integrity_only Median latency (us) 130 (1.82) 125 (5.36) grpc-java-java-single-throughput-integrity_only Actual QPS 593 (5.14) 587 (3.76) QPS per Client CPU 502 (4.51) 494 (6.92) ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would reduce the amount of direct buffer allocations, especially with light traffic. This should mitigate internal issue b/143075435
The change is currently optional and is only effective if system property "io.grpc.netty.useCustomAllocator" is set to "true" ignoring the case.
Internal benchmark results (median of 5 runs) doesn't show any significant change: