core: keep round_robin lb subchannel in TRANSIENT_FAILURE until becoming READY #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…robin_lb_subchannel_state_transition
…ng into each subchannel's state.
voidzcy
changed the title
ejona86
reviewed
Apr 3, 2020
voidzcy
changed the title
ejona86
approved these changes
Apr 3, 2020
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
…ing READY (grpc#6657) Make each subchannel created by RR stay in TRANSIENT_FAILURE state until READY. That is, each subchannel ignores consequent non-READY states after TRANSIENT_FAILURE.
zhangkun83
added a commit
to zhangkun83/grpc-java
that referenced
this pull request
Jan 15, 2021
…READY If all RR servers are unhealthy, it's possible that at least one connection is CONNECTING at every moment which causes RR to stay in CONNECTING. It's better to keep the TRANSIENT_FAILURE state in that case so that fail-fast RPCs can fail fast. The same changes have been made for RoundRobinLoadBalancer in grpc#6657
zhangkun83
added a commit
that referenced
this pull request
Jan 15, 2021
…READY (#7816) If all RR servers are unhealthy, it's possible that at least one connection is CONNECTING at every moment which causes RR to stay in CONNECTING. It's better to keep the TRANSIENT_FAILURE state in that case so that fail-fast RPCs can fail fast. The same changes have been made for RoundRobinLoadBalancer in #6657
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid buffering RPCs when subchannel is CONNECTING after being TRANSIENT_FAILURE.
See #6650 for description of the issue. This PR fixes RR load balancer only.