Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alts: _Actually_ use Conscrypt when available #6672

Merged
merged 1 commit into from Feb 4, 2020

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Feb 4, 2020

Previously the check for Conscrypt would always fail because CONSCRYPT
was guaranteed to be null.

Previously the check for Conscrypt would always fail because CONSCRYPT
was guaranteed to be null.
Copy link
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit 5b726c0 into grpc:master Feb 4, 2020
@ejona86 ejona86 deleted the alts-conscrypt-actually branch February 4, 2020 01:38
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Feb 4, 2020
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label Mar 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants