Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: add grpc-android into main build #6793

Merged
merged 3 commits into from Mar 4, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Mar 2, 2020

For #6775. Basically a mirror of #6132, which was for grpc-cronet. After this change, dependencies in grpc-android is kept in sync with main build.

This change also migrated deprecated Robolectric methods to androidx.test methods. See Robolectric migration guide.

Robolectric 4.0 includes initial support for androidx.test APIs. We strongly recommend adding androidx.test:core:1.0.0 as a test dependency and using those APIs whenever possible rather than using Robolectric-specific APIs.

Copy link
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good. make sure it generates pom identical or close enough to existing.

@voidzcy voidzcy merged commit 5ba663b into grpc:master Mar 4, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
Add grpc-android into main build. grpc-android will be built if Gradle option skipAndroid is false. This change also migrates deprecated Robolectric methods to androidx.test methods.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants