Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netty: prevent interruption during bind from leaking channel #6867

Merged
merged 1 commit into from Mar 28, 2020
Merged

netty: prevent interruption during bind from leaking channel #6867

merged 1 commit into from Mar 28, 2020

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Mar 27, 2020

Fixes #6850

@ejona86 ejona86 requested a review from creamsoup March 27, 2020 19:37
creamsoup
creamsoup approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 closed this Mar 27, 2020
@ejona86 ejona86 reopened this Mar 27, 2020
@ejona86 ejona86 merged commit 2c250ac into grpc:master Mar 28, 2020
@ejona86 ejona86 deleted the netty-interrupted-start branch March 28, 2020 00:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creamsoup creamsoup creamsoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port is bound if start is Interrupted
2 participants
@ejona86 @creamsoup