Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

okhttp: use new APIs to configure TLS in Android (roll forward #6959) #6960

Merged
merged 3 commits into from Apr 22, 2020
Merged

okhttp: use new APIs to configure TLS in Android (roll forward #6959) #6960

merged 3 commits into from Apr 22, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Apr 21, 2020

Roll-forward of ee8b395

The added unit test doesn't really reveal the issue being fixed, as the breakage happens only on Android. Just leave it for coverage.

@voidzcy voidzcy requested a review from ejona86 April 21, 2020 23:35
@voidzcy voidzcy merged commit b8bcf98 into grpc:master Apr 22, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@voidzcy @dfawley
okhttp: use new APIs to configure TLS in Android (roll forward grpc#6959
627aaeb 
) (grpc#6960)

* Revert "okhttp: revert changes for using new APIs to configure TLS in Android (grpc#6959)"

This reverts commit ee8b395.

Roll forward with adding manual check if hostname contains underscore, as Android's URI implementation allows underscore in hostsname.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@voidzcy @ejona86