New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netty should use BDP by default #7007
Comments
@creamsoup Using old versions, from which version manually enable BDP is suggested?
|
We will want to reduce the window size, but for now let's keep the initial window size the same. Then over the course of a few releases we could reduce it down to ~64K, which will align with the other languages and greatly reduce the amount of buffering in many systems. |
@wujun8, the PR mentioned was just recently merged. It isn't available in a release yet. The next release is scheduled for June 2nd. |
@ejona86 commented on 2020年5月7日 GMT+8 上午12:10:
I noticed in other libs using grpc, they never enable the BDP switch, if I manually enable BDP, is it OK in old versions? Doing like this in static block:
|
Those internal APIs shouldn't be used by users hence it is internal. It may not work correctly in some environments (that's why the change has some other stuff in it). Unfortunately, java doesn't block you from using it. If you use it, you are on your own. |
Since now we expose Netty{Channel,Server}Builder#initialWindowUpdate via #6979. We should use it by default.
We probably need to use smaller windowSize than current
DEFAULT_FLOW_CONTROL_WINDOW
1MB.The text was updated successfully, but these errors were encountered: