Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetriableStream.Sublistener.onReady() has broken concurrency for hedging #7089

Closed
dapengzhang0 opened this issue Jun 3, 2020 · 1 comment
Closed

RetriableStream.Sublistener.onReady() has broken concurrency for hedging #7089

dapengzhang0 opened this issue Jun 3, 2020 · 1 comment
Assignees
@dapengzhang0
Labels
bug
Milestone
1.30

Comments

@dapengzhang0
Copy link
Member

dapengzhang0 commented Jun 3, 2020 •
edited

As mentioned in #6817 (comment), there could be multiple concurrent Sublistener.onReady() invocations. They should not all be propagated to the master listener which may cause excessive buffering.
@dapengzhang0 dapengzhang0 added this to the Next milestone Jun 3, 2020
@dapengzhang0 dapengzhang0 self-assigned this Jun 3, 2020
@dapengzhang0 dapengzhang0 mentioned this issue Jun 3, 2020
Merged
dapengzhang0 added a commit that referenced this issue Jun 4, 2020
@dapengzhang0
core: always propagate RetriableStream.Sublistener.onReady()
959769a 
This fixes #6817 for the normal retry case, although it makes the hedging issue #7089 more broken, and there is still space of optimization for normal retry.
dapengzhang0 added a commit to dapengzhang0/grpc-java that referenced this issue Jun 10, 2020
@dapengzhang0
core: always propagate RetriableStream.Sublistener.onReady()
86290d9 
This fixes grpc#6817 for the normal retry case, although it makes the hedging issue grpc#7089 more broken, and there is still space of optimization for normal retry.
dapengzhang0 added a commit to dapengzhang0/grpc-java that referenced this issue Jun 10, 2020
@dapengzhang0
core: always propagate RetriableStream.Sublistener.onReady()
d7eb5a0 
This fixes grpc#6817 for the normal retry case, although it makes the hedging issue grpc#7089 more broken, and there is still space of optimization for normal retry.
@dapengzhang0 dapengzhang0 mentioned this issue Jun 10, 2020
Merged
dapengzhang0 added a commit that referenced this issue Jun 10, 2020
@dapengzhang0
core: always propagate RetriableStream.Sublistener.onReady()
411aac0 
This fixes #6817 for the normal retry case, although it makes the hedging issue #7089 more broken, and there is still space of optimization for normal retry.
dfawley pushed a commit to dfawley/grpc-java that referenced this issue Jan 15, 2021
@dapengzhang0 @dfawley
core: always propagate RetriableStream.Sublistener.onReady()
9336a4b 
This fixes grpc#6817 for the normal retry case, although it makes the hedging issue grpc#7089 more broken, and there is still space of optimization for normal retry.
@dapengzhang0
Copy link
Member Author

The data race is fixed by #8566), but there are still excessive masterListener.onReady() which can be optimized but not broken now.

@dapengzhang0 dapengzhang0 modified the milestones: Next, 1.30 Jan 19, 2022
@ulfjack ulfjack mentioned this issue Feb 25, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dapengzhang0 dapengzhang0

Labels
bug
Projects
None yet
Milestone
1.30
Development

No branches or pull requests
1 participant
@dapengzhang0