api,core: add LoadBalancer.Helper#createResolvingOobChannelBuilder api #7136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * target string. The out-of-band channel doesn't have load-balancing. If multiple addresses | ||
| * are resolved for the target, the first working address will be used. | ||
| * target string. If multiple addresses are resolved for the target, the first working address | ||
| * will be used. |
There was a problem hiding this comment.
I think the last sentence is not needed as well. Basically it will use the balancer determined by the service config from the NameResolver or the default config.
voidzcy
reviewed
Jun 17, 2020
| } | ||
|
|
||
| @Override | ||
| public ManagedChannel createResolvingOobChannel(String target) { |
There was a problem hiding this comment.
Do you still need this overriding? Same for below.
There was a problem hiding this comment.
For below we definitely need.
There was a problem hiding this comment.
done. for the Forwarding one, i didn't change because the method is not final.
voidzcy
approved these changes
Jun 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows RLS or any LB to configure OobChannel such as service config.