Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: perform header matching on concatenated values #7215

Merged

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Jul 15, 2020

No description provided.

Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xds/src/main/java/io/grpc/xds/RouteMatch.java Show resolved Hide resolved
@voidzcy voidzcy merged commit 92f4842 into grpc:master Jul 15, 2020
@dapengzhang0
Copy link
Member

I think we need backport it.

@voidzcy voidzcy added the TODO:backport PR needs to be backported. Removed after backport complete label Jul 16, 2020
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Jul 16, 2020
Combine values of header fields with the same key to a comma-separated string before performing header matching.
voidzcy added a commit that referenced this pull request Jul 17, 2020
#7215) (#7225)

Combine values of header fields with the same key to a comma-separated string before performing header matching.
@voidzcy voidzcy removed the TODO:backport PR needs to be backported. Removed after backport complete label Jul 17, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
Combine values of header fields with the same key to a comma-separated string before performing header matching.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants