Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: add header matching special cases for hiding/exposing some gRPC headers #7224

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Jul 16, 2020

  • Expose "content-type" header (hard-coded) at header matching, pretend it's already there.
  • Hide "grpc-tags-bin", "grpc-trace-bin" and "grpc-previous-rpc-attempts", pretend they are not there.
  • Do not exclude binary headers from header matching, they can still be useful for present matchers (which checks if a given header present regardless its value).

Details in b/159631362

@voidzcy voidzcy closed this Jul 17, 2020
@voidzcy voidzcy reopened this Jul 17, 2020
@voidzcy voidzcy merged commit 1e238ee into grpc:master Jul 22, 2020
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Aug 11, 2020
…headers (grpc#7224)

Expose "content-type" header (hard-coded) at header matching, pretend it's already there.
voidzcy added a commit that referenced this pull request Aug 11, 2020
…headers (v1.31.x backport) (#7224) (#7313)

Expose "content-type" header (hard-coded) at header matching, pretend it's already there.
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
…headers (grpc#7224)

Expose "content-type" header (hard-coded) at header matching, pretend it's already there.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants