Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpclb: Make ATTR_LB_ADDRS public. #7230

Merged
merged 1 commit into from Jul 21, 2020
Merged

grpclb: Make ATTR_LB_ADDRS public. #7230

merged 1 commit into from Jul 21, 2020

Conversation

susinmotion
Copy link
Contributor

This is used for an internal name resolver.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 17, 2020 •
edited

CLA Check
The committers are authorized under a signed CLA.

ejona86
ejona86 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having NameResolvers use the internal API, it seems exposing this is fair. ATTR_LB_ADDR_AUTHORITY is useless without this attribute.

@ejona86 ejona86 requested a review from voidzcy July 21, 2020 17:48
@ejona86 ejona86 changed the title Make ATTR_LB_ADDRS public. grpclb: Make ATTR_LB_ADDRS public. Jul 21, 2020
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 21, 2020
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 21, 2020
@voidzcy voidzcy merged commit 2473110 into grpc:master Jul 21, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@susinmotion @dfawley
grpclb: Make ATTR_LB_ADDRS public (grpc#7230)
a76e0c6
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@voidzcy voidzcy voidzcy approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@susinmotion @voidzcy @ejona86 @grpc-kokoro