Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: implement XdsChannelCredentials #7497

Merged
merged 3 commits into from Oct 9, 2020
Merged

xds: implement XdsChannelCredentials #7497

merged 3 commits into from Oct 9, 2020

Conversation

sanjaypujare
Copy link
Contributor

@ejona86 PTAL.

ejona86
ejona86 reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair. Didn't approve since it is draft.

xds/src/main/java/io/grpc/xds/XdsChannelCredentials.java Show resolved Hide resolved
@sanjaypujare sanjaypujare marked this pull request as ready for review October 8, 2020 20:48
@sanjaypujare
Copy link
Contributor Author

Seems fair. Didn't approve since it is draft.

Removed draft...

@sanjaypujare
Copy link
Contributor Author

@ejona86 friendly ping. Let me know if you have more comments or if you are ready to approve.

@sanjaypujare sanjaypujare merged commit f9b428a into grpc:master Oct 9, 2020
@sanjaypujare sanjaypujare deleted the xdschannelcreds branch October 9, 2020 16:21
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@sanjaypujare @dfawley
xds: implement XdsChannelCredentials (grpc#7497)
d780573
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sanjaypujare @ejona86