Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServerCredentials #7601

Merged
merged 4 commits into from Nov 13, 2020
Merged

Add ServerCredentials #7601

merged 4 commits into from Nov 13, 2020

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Nov 7, 2020

This is very similar to the ChannelCredentials, except easier all around. The changes are split up similar to before, and most of it should feel very familiar.

@ejona86 ejona86 closed this Nov 9, 2020
@ejona86 ejona86 reopened this Nov 9, 2020
@ejona86
Copy link
Member Author

ejona86 commented Nov 9, 2020

Closed+reopened to trigger CLA check.

Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment about replacing "TODO" with the actual issue number in the experimentalApi annotation

@ejona86
Copy link
Member Author

ejona86 commented Nov 13, 2020

I've fixed the TODO links and squashed commits appropriately.

@ejona86 ejona86 merged commit ddd5dea into grpc:master Nov 13, 2020
@ejona86 ejona86 deleted the server-credentials branch November 13, 2020 19:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants