Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPCLB fails RPCs if gRPCLB server unavailable #7721

Open
ejona86 opened this issue Dec 11, 2020 · 2 comments
Open

gRPCLB fails RPCs if gRPCLB server unavailable #7721

ejona86 opened this issue Dec 11, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented Dec 11, 2020

This is split out of #7643 (comment):

The initial RPCs seem to fail because the picker is immediately failed when lb RPC fails and there are no backends. Changing the logic to try fallback backends first should be possible, but it also seems it will be a hard to define/implement all the edge cases.

@apolcyn, does it seem wrong that initial RPCs fail if gRPCLB server is unavailable, when fallback is available but hasn't been tried yet? It appears later RPCs would succeeded as the picker would be replaced to buffer further RPCs and eventually the fallback would come online. It seems like we may need to change this error behavior.

@ejona86 ejona86 added the bug label Dec 11, 2020
@ejona86 ejona86 added this to the Next milestone Dec 11, 2020
@apolcyn
Copy link
Contributor

apolcyn commented Dec 11, 2020

@apolcyn, does it seem wrong that initial RPCs fail if gRPCLB server is unavailable, when fallback is available but hasn't been tried yet? It appears later RPCs would succeeded as the picker would be replaced to buffer further RPCs and eventually the fallback would come online. It seems like we may need to change this error behavior.

Yes I agree that this current behavior seems not ideal. The behavior when the LB call fails should IMO be handled the same as when the connection to the LB service fails -- that is, I think we should enter fallback mode, and only fail RPCs if there is then a problem with the picker over the fallback addresses.

@dapengzhang0 dapengzhang0 assigned temawi and unassigned dapengzhang0 Feb 18, 2022
@temawi
Copy link
Contributor

temawi commented Sep 14, 2022

@apolcyn Do you think this one is still a relevant issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants