Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Add nullable annotation to trailersFromThrowable #7856

Merged
merged 1 commit into from Feb 9, 2021
Merged

api: Add nullable annotation to trailersFromThrowable #7856

merged 1 commit into from Feb 9, 2021

Conversation

ReginFell
Copy link
Contributor

@ReginFell ReginFell commented Feb 1, 2021 •
edited

At the moment Status.trailersFromThrowable() does not play well with Kotlin since compiler treats this functions as a null safe even though it is not.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 1, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

sanjaypujare
sanjaypujare approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voidzcy voidzcy added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Feb 9, 2021
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Feb 9, 2021
@voidzcy voidzcy changed the title Add nullable annotation to trailersFromThrowable api: Add nullable annotation to trailersFromThrowable Feb 9, 2021
@voidzcy voidzcy merged commit 9ba419a into grpc:master Feb 9, 2021
@ReginFell ReginFell deleted the improvement/add-nullable-annotation-to-from-trailers branch March 12, 2021 08:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sanjaypujare sanjaypujare sanjaypujare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ReginFell @sanjaypujare @voidzcy @grpc-kokoro