Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty 4.1.59 fixing temp file vulnerability (CVE-2021-21290) #7898

Closed
julianladisch opened this issue Feb 15, 2021 · 6 comments
Closed

Netty 4.1.59 fixing temp file vulnerability (CVE-2021-21290) #7898

julianladisch opened this issue Feb 15, 2021 · 6 comments

Comments

@julianladisch
Copy link

Netty 4.1.59 has been released that fixes a local information disclosure vulnerability in Netty on Unix-like systems due temporary files: GHSA-5mcr-gq6c-3hq2

Please update the dependencies to Netty 41.59 and TcNative 2.0.36,
and update the table listing the known to work version combinations https://github.com/grpc/grpc-java/security/policy#netty .

@voidzcy voidzcy added this to the 1.37 milestone Feb 16, 2021
@michaelbannister
Copy link

Does this vulnerability actually affect grpc, since based on that security advisory it seems only to be related to http?

@stefanscheidt
Copy link

dependency-check-maven does complain as it finds the old and affected Netty POM in the grpc jar. One has to suppress the CVE for the Netty version included in that jar.

@sergiitk sergiitk modified the milestones: 1.37, 1.38 Mar 25, 2021
@btinnel
Copy link

btinnel commented Mar 30, 2021

Note that Netty 4.1.59 also has a vulnerability (GHSA-wm47-8v5p-wjpj), so Netty 4.1.60 should be used instead.

@XanderAtBackboneSystems
Copy link

And even to version 4.1.61 to resolve https://nvd.nist.gov/vuln/detail/CVE-2021-21409 as well.

@mbard
Copy link

mbard commented Apr 27, 2021

Any updates regarding the update of Netty.

@ericgribkoff ericgribkoff modified the milestones: 1.38, 1.39 May 6, 2021
@ejona86 ejona86 removed this from the 1.39 milestone May 11, 2021
@ejona86
Copy link
Member

ejona86 commented May 11, 2021

gRPC is not impacted by the multipart issue nor the request smuggling. It is safe to use grpc-netty-shaded. If you are using grpc-netty along with netty in your application, you'd have to see whether the rest of your application is impacted and upgrade Netty accordingly. gRPC was incompatible with Netty 4.1.60 when it was initially released, but that was resolved by #7953 . We have not done strenuous testing with the newer versions of Netty though.

As I mention in #7953, we were unable to upgrade to versions before 4.1.61 because netty-jni-util was incompatible with static linking that is used in some environments.

Concerning dependency-check-maven, I have no familiarity with that plugin, but it sounds like it is related to the pom.properties mention in #8077 . I might remove end up removing the pom.properties from grpc-netty-shaded.

FWIW, we are working on updating Netty, but not for security reasons.

@ejona86 ejona86 closed this as completed May 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants