services: move classes with protobuf dependency into io.grpc.protobuf.services #8056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpc.protobuf.services. Create a forwarding class for HealthStatusManager to avoid breakages. Others are mostly fine, as few people are using them.
… existing users migrate.
…_io_grpc_services
… deprecated and suggest users to migrate new ones in io.grpc.protobuf.services
voidzcy
force-pushed
the
impl/clean_up_io_grpc_services
branch
from
280ba67
to
d8412ab
Compare
voidzcy
force-pushed
the
impl/clean_up_io_grpc_services
branch
from
186f7a5
to
9989179
Compare
voidzcy
commented
Apr 13, 2021
services/src/main/java/io/grpc/protobuf/services/BinaryLogProvider.java
Outdated
Show resolved
Hide resolved
voidzcy
force-pushed
the
impl/clean_up_io_grpc_services
branch
from
8fb76c8
to
851628c
Compare
For a bit more context, it isn't just for organization. But to avoid protobuf dependency in some classes. That is to say, it is for dependency organization, and not as much "make things look nice" organization. |
ejona86
reviewed
Apr 15, 2021
services/src/main/java/io/grpc/protobuf/services/BinaryLogProvider.java
Outdated
Show resolved
Hide resolved
services/src/test/java/io/grpc/services/ChannelzProtoUtilTest.java
Outdated
Show resolved
Hide resolved
services/src/test/java/io/grpc/services/BinaryLogProviderTest.java
Outdated
Show resolved
Hide resolved
services/src/main/java/io/grpc/protobuf/services/BinaryLogProvider.java
Outdated
Show resolved
Hide resolved
voidzcy
force-pushed
the
impl/clean_up_io_grpc_services
branch
from
72ea3bb
to
1951bc2
Compare
voidzcy
force-pushed
the
impl/clean_up_io_grpc_services
branch
from
e648129
to
312fe1c
Compare
voidzcy
force-pushed
the
impl/clean_up_io_grpc_services
branch
from
312fe1c
to
3f4dd94
Compare
voidzcy
commented
Apr 16, 2021
| @@ -19,6 +19,7 @@ | |||
| import io.grpc.BindableService; | |||
| import io.grpc.ExperimentalApi; | |||
| import io.grpc.ServerServiceDefinition; | |||
| import io.grpc.protobuf.services.ChannelzService; | |||
There was a problem hiding this comment.
This dependency should be ok. Or we can change it when making io.grpc.protobuf.services a separate artifact.
|
All addressed and self-reviewed. Should be good now. PTAL. |
ejona86
approved these changes
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To separately manage services/classes with and without protobuf dependency in services package, we are moving classes with protobuf dependency into
io.grpc.protobuf.services. This includes healthchecking, reflection, channelz, and binlogging.Forwarding classes are created to avoid breaking existing users, while they are marked as deprecated to notify users to migrate.