Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub: Document StreamObserver is an async API #8449

Merged
merged 2 commits into from Aug 30, 2021

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Aug 25, 2021

Missing docs were brought up in #8423

CC @morgwai

@ejona86
Copy link
Member Author

ejona86 commented Aug 25, 2021

Hold up for a second. I'm going to add some more text.

@ejona86
Copy link
Member Author

ejona86 commented Aug 30, 2021

@dapengzhang0, friendly ping

Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit 5cc94a5 into grpc:master Aug 30, 2021
@ejona86 ejona86 deleted the streamobserver-is-async branch August 30, 2021 18:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants