okhttp: introduced new TLS1.2 cipher suites and internal okhttp implementation for TLS1.3 prepared. #8650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't review until you agree to the CLA. If you have trouble, just tell us. |
I agreed the CLA, but it seems that I used the wrong username for my initial commit. Is there a way to change this? or shall I close the PR and create a new one with the commits issued with the correct username? |
|
@beatrausch, you can do whatever rewriting of the commits you need (e.g., via rebase) and then just force-push to your fork's branch. This PR will track that branch, and then notice the new authorship. |
Additional TLS1.2 cipher suites added Default connection spec synced with netty Introduced new method for internal connection in OkHttpChannelBuilder
beatrausch
force-pushed
the
okhttp-additional-ciphers
branch
from
daf3c20
to
cdb8dc5
Compare
|
@beatrausch Can you please drop unrelated commits? |
beatrausch
force-pushed
the
okhttp-additional-ciphers
branch
from
cdb8dc5
to
b861c5e
Compare
Sorry, I dropped the commits |
ejona86
reviewed
Nov 11, 2021
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
Nov 16, 2021
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
dapengzhang0
approved these changes
Nov 17, 2021
|
@beatrausch, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces new TLS 1.2 cipher suites (#8610) and prepares the internal okhttp implementation for TLS1.3. A new method for using a internal ConnectionSpec was added to be able to use the newly introduced cipher suites in the OkHttpChannelBuilder. Okhttp cipher suites synchronized with the ones form netty.