xds: fix xdsClient resource not exist for invalid resource, fix xdsServerWrapper start on resource not exist #8660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds-server-start
…rapper start on resource not exist
dapengzhang0
reviewed
Nov 8, 2021
xds/src/test/java/io/grpc/xds/XdsClientWrapperForServerSdsTestMisc.java
Outdated
Show resolved
Hide resolved
dapengzhang0
requested changes
Nov 8, 2021
xds/src/test/java/io/grpc/xds/XdsClientWrapperForServerSdsTestMisc.java
Outdated
Show resolved
Hide resolved
dapengzhang0
approved these changes
Nov 8, 2021
YifeiZhuang
added a commit
to YifeiZhuang/grpc-java
that referenced
this pull request
Nov 11, 2021
…rverWrapper start on resource not exist (grpc#8660) Fix bugs: 1. Invalid resource at xdsClient, the watcher should have been delivered an error instead of resource not found. 2. If the resource is properly determined to not exist, it shouldn't cause start() to fail. From A36 xDS for Servers: "XdsServer's start must not fail due to transient xDS issues, like missing xDS configuration from the xDS server."
YifeiZhuang
added a commit
that referenced
this pull request
Nov 11, 2021
…rverWrapper start on resource not exist (1.42.x backport) (#8690) * xds: remove filter chain uuid name generator (#8663) Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it. An empty name is now allowed. The name is currently only used for debug purpose. * xds: fix xdsClient resource not exist for invalid resource, fix xdsServerWrapper start on resource not exist (#8660) Fix bugs: 1. Invalid resource at xdsClient, the watcher should have been delivered an error instead of resource not found. 2. If the resource is properly determined to not exist, it shouldn't cause start() to fail. From A36 xDS for Servers: "XdsServer's start must not fail due to transient xDS issues, like missing xDS configuration from the xDS server."
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8657
cc. @sanjaypujare