Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: remove filter chain uuid name generator #8663

Merged
merged 1 commit into from Nov 4, 2021
Merged

xds: remove filter chain uuid name generator #8663

merged 1 commit into from Nov 4, 2021

Conversation

YifeiZhuang
Copy link
Contributor

b/203318463

@YifeiZhuang YifeiZhuang added the TODO:backport PR needs to be backported. Removed after backport complete label Nov 4, 2021
ejona86
ejona86 approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include more information about why we are doing this (because it breaks de-duplication detection which causes XdsServer to cycle connections). Also, the commit doesn't include "xds: " in its title.

@YifeiZhuang YifeiZhuang merged commit a5c526c into grpc:master Nov 4, 2021
@YifeiZhuang YifeiZhuang added TODO:backport PR needs to be backported. Removed after backport complete and removed TODO:backport PR needs to be backported. Removed after backport complete labels Nov 4, 2021
@YifeiZhuang YifeiZhuang deleted the filter-chain-uuid-remove branch November 11, 2021 00:10
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Nov 11, 2021
@YifeiZhuang
xds: remove filter chain uuid name generator (grpc#8663)
2de0166 
Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it.
An empty name is now allowed. The name is currently only used for debug purpose.
@YifeiZhuang YifeiZhuang mentioned this pull request Nov 11, 2021
Merged
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label Nov 11, 2021
YifeiZhuang added a commit that referenced this pull request Nov 11, 2021
@YifeiZhuang
xds: remove filter chain uuid name generator (#8663) (#8688)
c818289 
Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it.
An empty name is now allowed. The name is currently only used for debug purpose.
YifeiZhuang added a commit that referenced this pull request Nov 11, 2021
@YifeiZhuang
xds: fix xdsClient resource not exist for invalid resource, fix xdsSe…
a25472e 
…rverWrapper start on resource not exist (1.42.x backport) (#8690)

* xds: remove filter chain uuid name generator (#8663)

Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it.
An empty name is now allowed. The name is currently only used for debug purpose.

* xds: fix xdsClient resource not exist for invalid resource, fix xdsServerWrapper start on resource not exist (#8660)

Fix bugs:
1. Invalid resource at xdsClient, the watcher should have been delivered an error instead of resource not found.
2. If the resource is properly determined to not exist, it shouldn't cause start() to fail. From A36 xDS for Servers:
"XdsServer's start must not fail due to transient xDS issues, like missing xDS configuration from the xDS server."
dapengzhang0 pushed a commit to dapengzhang0/grpc-java that referenced this pull request Dec 2, 2021
@YifeiZhuang @dapengzhang0
xds: remove filter chain uuid name generator (grpc#8663)
865ce18 
Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it.
An empty name is now allowed. The name is currently only used for debug purpose.
@dapengzhang0 dapengzhang0 mentioned this pull request Dec 2, 2021
Merged
dapengzhang0 pushed a commit to dapengzhang0/grpc-java that referenced this pull request Dec 2, 2021
@YifeiZhuang @dapengzhang0
xds: remove filter chain uuid name generator (grpc#8663)
b254abd 
Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it.
An empty name is now allowed. The name is currently only used for debug purpose.
@dapengzhang0 dapengzhang0 mentioned this pull request Dec 2, 2021
Merged
dapengzhang0 pushed a commit that referenced this pull request Dec 2, 2021
@YifeiZhuang @dapengzhang0
xds: remove filter chain uuid name generator (#8663)
64eeb67 
Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it.
An empty name is now allowed. The name is currently only used for debug purpose.
dapengzhang0 pushed a commit that referenced this pull request Dec 2, 2021
@YifeiZhuang @dapengzhang0
xds: remove filter chain uuid name generator (#8663)
51de54e 
Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it.
An empty name is now allowed. The name is currently only used for debug purpose.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YifeiZhuang @ejona86