core: Race condition in idleTimer & ManagedChannel#enterIdle #8746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Dec 14, 2021
| @@ -349,6 +349,9 @@ public InternalLogId getLogId() { | |||
|
|
|||
| @Override | |||
| public void run() { | |||
| if (lbHelper == null) { | |||
There was a problem hiding this comment.
Let's add a comment like // Workaround timer scheduled while in idle mode. This can happen from handleNotInUse() after an explicit enterIdleMode() by the user. Protecting here as other locations are a bit too subtle.
And then it'll be clear it is load-bearing when we rework things to simplify.
|
/easycla |
|
|
|
@Spikhalskiy Can you please sign the CLA? |
|
@dapengzhang0 done. Thank you for preparing the PR! |
|
@Spikhalskiy Thank you for reporting the issue and providing the hot fix. |
dapengzhang0
added
the
TODO:backport
This was referenced Dec 15, 2021
dapengzhang0
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Spikhalskiy/grpc-java@6d260b8
Hot fix of #8714