-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xDS ADS reconnection should not spam logs #8886
Comments
Google-internal copy of issue: b/207626836 |
Comment from dapengzhang0 on b/207626836:
|
ejona86
added a commit
to ejona86/grpc-java
that referenced
this issue
Feb 23, 2022
Workaround for grpc#8886, as we wait on a real fix. The regular load balancing disconnections are confusing users and will train users to start ignoring gRPC warnings. At present, it is better to have no log than excessively log.
ejona86
added a commit
that referenced
this issue
Feb 23, 2022
Workaround for #8886, as we wait on a real fix. The regular load balancing disconnections are confusing users and will train users to start ignoring gRPC warnings. At present, it is better to have no log than excessively log.
ejona86
added a commit
to ejona86/grpc-java
that referenced
this issue
Feb 23, 2022
Workaround for grpc#8886, as we wait on a real fix. The regular load balancing disconnections are confusing users and will train users to start ignoring gRPC warnings. At present, it is better to have no log than excessively log.
ejona86
added a commit
that referenced
this issue
Feb 24, 2022
Workaround for #8886, as we wait on a real fix. The regular load balancing disconnections are confusing users and will train users to start ignoring gRPC warnings. At present, it is better to have no log than excessively log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As recently seen:
This is being logged from ManagedChannelImpl:
grpc-java/core/src/main/java/io/grpc/internal/ManagedChannelImpl.java
Lines 1891 to 1893 in 7308d92
I'm surprised that log statement exists as a WARNING. Seems it was introduced in the large ManagedChannelImpl2 rewrite (#2530).
There's two cases this WARNING could happen:
So that means we should make two changes (one to ManagedChannelImpl, one to xds).
I'd hope we'd never log WARNINGs like this, but it is a bit hard of a situation and I don't want us to let perfect be the enemy of good. At least for xDS, we should be able to avoid logging except when ADS stream creation fails.
I've seen #8773, but it looks incomplete, as it'd need to handle the "never received a response" case.
CC @erikjoh, @dapengzhang0, @YifeiZhuang, @sergiitk
The text was updated successfully, but these errors were encountered: