New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose SecurityLevel on server-side #8943
Conversation
|
1b247d6
to
16428c1
Compare
16428c1
to
8ca5e58
Compare
@sanjaypujare, what's the state of this? |
I'll take care of this today - for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sanjaypujare, shouldn't this have had a second maintainer review? |
Yes, you are right. What do we do now? Do you want to review? If you see issues we can revert and ask them to resubmit. Sorry about that. |
I'll review, probably later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I could have some nits, and getAttributes()
should never be null. But this is fine.
Thanks. So no more action needed. |
This is a shot to #7719.
Added a new method to ServerCall which returns
SecurityLevel.NONE
and ServerCallImpl returns the security levelgetAttributes().get(ATTR_SECURITY_LEVEL),
in the case of uncertainty will return a lower level of security.