Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SecurityLevel on server-side #8943

Merged
merged 1 commit into from May 17, 2022

Conversation

ovidiutirla
Copy link
Contributor

@ovidiutirla ovidiutirla commented Feb 25, 2022

This is a shot to #7719.
Added a new method to ServerCall which returns SecurityLevel.NONE and ServerCallImpl returns the security level getAttributes().get(ATTR_SECURITY_LEVEL), in the case of uncertainty will return a lower level of security.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 25, 2022

CLA Signed

The committers are authorized under a signed CLA.

@ovidiutirla ovidiutirla marked this pull request as draft February 26, 2022 21:22
@ovidiutirla ovidiutirla marked this pull request as ready for review February 26, 2022 21:22
@ejona86
Copy link
Member

ejona86 commented May 16, 2022

@sanjaypujare, what's the state of this?

@sanjaypujare
Copy link
Contributor

I'll take care of this today - for sure.

Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanjaypujare sanjaypujare added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label May 16, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label May 16, 2022
@sanjaypujare sanjaypujare merged commit a88f19f into grpc:master May 17, 2022
@ejona86
Copy link
Member

ejona86 commented May 17, 2022

@sanjaypujare, shouldn't this have had a second maintainer review?

@sanjaypujare
Copy link
Contributor

Yes, you are right. What do we do now? Do you want to review? If you see issues we can revert and ask them to resubmit. Sorry about that.

@ejona86
Copy link
Member

ejona86 commented May 17, 2022

I'll review, probably later today.

@ejona86 ejona86 self-requested a review May 17, 2022 17:03
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I could have some nits, and getAttributes() should never be null. But this is fine.

@sanjaypujare
Copy link
Contributor

LGTM.

I could have some nits, and getAttributes() should never be null. But this is fine.

Thanks. So no more action needed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants