Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: bump PerfMark to 0.25.0 #8948

Merged
merged 3 commits into from Mar 29, 2022
Merged

Conversation

carl-mastrangelo
Copy link
Contributor

Perfmark 0.24.0 is much more defensive about class initialization failures, and speeds up class load time by a few millis.

@carl-mastrangelo
Copy link
Contributor Author

Hi, Friendly ping @dapengzhang0

@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 21, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 21, 2022
@ran-su
Copy link
Member

ran-su commented Mar 21, 2022

Since the internal perfmark is not at 0.25.0 yet, I will do an import of perfmark first. If that works fine then I'll come back and merge this PR.

@ran-su
Copy link
Member

ran-su commented Mar 23, 2022

It looks like this PR cannot be merged before bumping the google-cloud-logging version.

@carl-mastrangelo
Copy link
Contributor Author

@ran-su can you make that change? I'm uncertain how to make the necessary changes.

@ejona86
Copy link
Member

ejona86 commented Mar 28, 2022

The process here is now much easier since #8238 . We no longer require all versions to be identical, but notice when Maven would downgrade a version. When that happens we just need to re-define the downgraded dependency higher in the dependency tree, or potentially just change the dependency order. Those are the normal steps to resolve requireUpperBoundDeps failures in Maven.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 28, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 28, 2022
@ejona86 ejona86 merged commit 6554061 into grpc:master Mar 29, 2022
@carl-mastrangelo carl-mastrangelo deleted the bumpperfmark branch March 29, 2022 18:14
temawi pushed a commit to temawi/grpc-java that referenced this pull request Apr 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants