okhttp: make okhttp dependencies compile only #8971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaypujare
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
ejona86
reviewed
Mar 18, 2022
ejona86
approved these changes
Mar 21, 2022
|
Error from Android CI. Hmm... getMethod() calls getDeclaredMethods0(). That means we can't do any reflection on the class? We could workaround the problem by adding okhttp as a dependency of grpc-android. We could also use a different class for the reflection; OkHttpChannelProvider would be a good candidate. Let's avoid this problem in this PR, so we can make forward progress. Let's keep okhttp as an API dependency in this PR. Today I'll try changing the reflection to OkHttpChannelProvider. |
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Mar 21, 2022
Doing any reflection on OkHttpChannelBuilder requires that all methods can have their arguments resolved. We'd like to make okhttp an optional dependency (to support okhttp 2 and 3/4 simultaneously). But making okhttp optional means we can no longer construct OkHttpChannelBuilder reflectively. We swap to the Provider that doesn't have this problem. See grpc#8971. Note that ManagedChannelProvider itself only exposes its methods as protected, so they wouldn't be accessible. However OkHttpChannelProvider has its methods public. It is an open question of whether ManagedChannelProvider's methods should become public, but in any case we can hide a public OkHttpChannelProvider inside a package-private class so it is only accessable via reflection. So this code assuming public methods doesn't prevent future implementation hiding.
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Mar 21, 2022
Doing any reflection on OkHttpChannelBuilder requires that all methods can have their arguments resolved. We'd like to make okhttp an optional dependency (to support okhttp 2 and 3/4 simultaneously). But making okhttp optional means we can no longer construct OkHttpChannelBuilder reflectively. We swap to the Provider that doesn't have this problem. See grpc#8971. Note that ManagedChannelProvider itself only exposes its methods as protected, so they wouldn't be accessible. However OkHttpChannelProvider has its methods public. It is an open question of whether ManagedChannelProvider's methods should become public, but in any case we can hide a public OkHttpChannelProvider inside a package-private class so it is only accessable via reflection. So this code assuming public methods doesn't prevent future implementation hiding.
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Mar 21, 2022
Doing any reflection on OkHttpChannelBuilder requires that all methods can have their arguments resolved. We'd like to make okhttp an optional dependency (to support okhttp 2 and 3/4 simultaneously). But making okhttp optional means we can no longer construct OkHttpChannelBuilder reflectively. We swap to the Provider that doesn't have this problem. See grpc#8971. Note that ManagedChannelProvider itself only exposes its methods as protected, so they wouldn't be accessible. However OkHttpChannelProvider has its methods public. It is an open question of whether ManagedChannelProvider's methods should become public, but in any case we can hide a public OkHttpChannelProvider inside a package-private class so it is only accessable via reflection. So this code assuming public methods doesn't prevent future implementation hiding.
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Mar 21, 2022
Doing any reflection on OkHttpChannelBuilder requires that all methods can have their arguments resolved. We'd like to make okhttp an optional dependency (to support okhttp 2 and 3/4 simultaneously). But making okhttp optional means we can no longer construct OkHttpChannelBuilder reflectively. We swap to the Provider that doesn't have this problem. See grpc#8971. Note that ManagedChannelProvider itself only exposes its methods as protected, so they wouldn't be accessible. However OkHttpChannelProvider has its methods public. It is an open question of whether ManagedChannelProvider's methods should become public, but in any case we can hide a public OkHttpChannelProvider inside a package-private class so it is only accessable via reflection. So this code assuming public methods doesn't prevent future implementation hiding.
|
CC @YifeiZhuang, @temawi |
|
@beatrausch, actually. You can hold-off. We can just make sure my PR goes in first. Changing this PR now would mean changing the PR title and some other stuff. It turned out I made my changes quickly, so this is probably fine as-is. |
Ok |
ejona86
added a commit
that referenced
this pull request
Mar 24, 2022
Doing any reflection on OkHttpChannelBuilder requires that all methods can have their arguments resolved. We'd like to make okhttp an optional dependency (to support okhttp 2 and 3/4 simultaneously). But making okhttp optional means we can no longer construct OkHttpChannelBuilder reflectively. We swap to the Provider that doesn't have this problem. See #8971. Note that ManagedChannelProvider itself only exposes its methods as protected, so they wouldn't be accessible. However OkHttpChannelProvider has its methods public. It is an open question of whether ManagedChannelProvider's methods should become public, but in any case we can hide a public OkHttpChannelProvider inside a package-private class so it is only accessable via reflection. So this code assuming public methods doesn't prevent future implementation hiding.
|
#9003 is merged. Re-running the Android CI. |
|
@YifeiZhuang, could you take a look? |
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Mar 31, 2022
…)" This partly reverts b20ce17 because it is dependent on cda0e9d which is being reverted as it is incompatible with Proguard without configuration (e.g., isAvailable() may not be available and would need a -keep). While the code no longer uses compileOnly, the compatibility still remains, so it would be possible for users to exclude the okhttp dependency if they don't use AndroidChannelBuilder.
temawi
pushed a commit
to temawi/grpc-java
that referenced
this pull request
Apr 8, 2022
Doing any reflection on OkHttpChannelBuilder requires that all methods can have their arguments resolved. We'd like to make okhttp an optional dependency (to support okhttp 2 and 3/4 simultaneously). But making okhttp optional means we can no longer construct OkHttpChannelBuilder reflectively. We swap to the Provider that doesn't have this problem. See grpc#8971. Note that ManagedChannelProvider itself only exposes its methods as protected, so they wouldn't be accessible. However OkHttpChannelProvider has its methods public. It is an open question of whether ManagedChannelProvider's methods should become public, but in any case we can hide a public OkHttpChannelProvider inside a package-private class so it is only accessable via reflection. So this code assuming public methods doesn't prevent future implementation hiding.
temawi
pushed a commit
to temawi/grpc-java
that referenced
this pull request
Apr 8, 2022
* okhttp: forked required files to make okhttp dep compile only * okhttp: forked missing file to make okhttp dep compile only * okhttp: moved url and request files to proxy packge * okhttp: removed unused methods from forked files; fixed build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes okhttp dependencies compile only. The PR is related to #6119 #8732 and is the base to add okhttp3 in the public API. For the implementation the required okhttp2 files had been forked.