Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting gRPClb initial fallback timeout by service config #8980

Merged
merged 2 commits into from Mar 16, 2022

Conversation

ZhouyihaiDing
Copy link
Contributor

The initial fallback timeout configuration is added to the service config in grpc/grpc-proto#105

Copy link
Member

@ran-su ran-su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-su ran-su requested a review from ejona86 March 15, 2022 16:56
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that looks like a bug. Otherwise LGTM

@sanjaypujare
Copy link
Contributor

@ZhouyihaiDing are you able to merge this now?

@ran-su ran-su merged commit ad2c0f9 into grpc:master Mar 16, 2022
temawi pushed a commit to temawi/grpc-java that referenced this pull request Apr 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants